Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: speedup cancellation #10579

Merged
merged 1 commit into from
Mar 12, 2021
Merged

fix: speedup cancellation #10579

merged 1 commit into from
Mar 12, 2021

Conversation

shanejonas
Copy link
Contributor

fixes #7305

Explanation:
Speeding up cancelled transactions would send the original transaction.

Manual testing steps:

  • need latest ganache run separately from dev env:
    • npm install -g ganache@internal
    • ganache --mnemonic "phrase upgrade clock rough situate wedding elder clever doctor stamp excess tent" --blockTime 50
  • send tx to another account
  • hit cancel button
  • need to customize gas to be > 10% for ganache testing speedup/cancellation
  • hit speedup this cancellation button
  • need to customize gas to be > 10% for ganache testing speedup/cancellation

@shanejonas shanejonas requested a review from a team as a code owner March 3, 2021 21:57
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@shanejonas shanejonas requested a review from Gudahtt March 3, 2021 21:58
@shanejonas shanejonas force-pushed the fix/speedup-cancellation branch 2 times, most recently from f7caa07 to e568924 Compare March 3, 2021 22:33
@metamaskbot
Copy link
Collaborator

Builds ready [e568924]
Page Load Metrics (633 ± 51 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint46856294
domContentLoaded39379563210551
load39479663310551
domInteractive39379563210551

Gudahtt
Gudahtt reviewed Mar 4, 2021
View reviewed changes
ui/app/hooks/useCancelTransaction.js Outdated Show resolved Hide resolved
ui/app/hooks/useCancelTransaction.js Show resolved Hide resolved
ui/app/hooks/useCancelTransaction.js Outdated Show resolved Hide resolved
@metamaskbot
Copy link
Collaborator

Builds ready [bfdc431]
Page Load Metrics (606 ± 28 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint488259105
domContentLoaded3816766045828
load3836786065828
domInteractive3816766045828

@shanejonas shanejonas force-pushed the fix/speedup-cancellation branch 2 times, most recently from 13ad5d1 to f3c9378 Compare March 5, 2021 21:41
@metamaskbot
Copy link
Collaborator

Builds ready [f3c9378]
Page Load Metrics (650 ± 27 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint51936394
domContentLoaded4727246485526
load4737316505527
domInteractive4717246485526

@shanejonas shanejonas force-pushed the fix/speedup-cancellation branch from f3c9378 to 21a8aa8 Compare March 5, 2021 23:44
@metamaskbot
Copy link
Collaborator

Builds ready [21a8aa8]
Page Load Metrics (566 ± 24 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint43665584
domContentLoaded3616135645024
load3636145665124
domInteractive3616125645024

@shanejonas shanejonas force-pushed the fix/speedup-cancellation branch from 21a8aa8 to 42e0831 Compare March 11, 2021 22:55
@metamaskbot
Copy link
Collaborator

Builds ready [42e0831]
Page Load Metrics (645 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint46776084
domContentLoaded4028066449144
load4038076459144
domInteractive4028066449144

@shanejonas shanejonas force-pushed the fix/speedup-cancellation branch from 42e0831 to f696205 Compare March 12, 2021 00:50
@metamaskbot
Copy link
Collaborator

Builds ready [f696205]
Page Load Metrics (611 ± 31 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint478258105
domContentLoaded3416676096531
load3436686116431
domInteractive3416676096531

Gudahtt
Gudahtt approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shanejonas shanejonas merged commit b21cc56 into develop Mar 12, 2021
@shanejonas shanejonas deleted the fix/speedup-cancellation branch March 12, 2021 19:26
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@NiranjanaBinoy NiranjanaBinoy Awaiting requested review from NiranjanaBinoy

@brad-decker brad-decker Awaiting requested review from brad-decker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Speeding up cancelled transactions resends the transaction you wanted to cancel
4 participants
@shanejonas @metamaskbot @Gudahtt @brad-decker